[FEAT] #257 - 명함 그룹뷰 인파이나이트스크롤 구현 #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prepareForReuse 로 셀 초기화 - 명함 추가, 명함큐알 추가, 명함삭제, 큐알스캔 뒤로가기, 그룹 편집 뒤로가기 시에 그룹뷰 갱신 노티 추가 - viewWillAppear 에서 구현할라했지만 컬렉션뷰 맨 위로 올리는 과정이 추가되기 위해서 노티 사용 - 무한스크롤 구현 - 현재 맨 위로 올리기 위해서 1초의 딜레이를 주고 있는데 좀 더 고민해보겠습니당
dlwns33
approved these changes
Dec 29, 2021
Comment on lines
+31
to
44
| override func prepareForReuse() { | ||
| super.prepareForReuse() | ||
|
|
||
| backgroundImageView.image = UIImage() | ||
| titleLabel.text = "" | ||
| descriptionLabel.text = "" | ||
| userNameLabel.text = "" | ||
| birthLabel.text = "" | ||
| mbtiLabel.text = "" | ||
| instagramIDLabel.text = "" | ||
| mbtiLabel.text = "" | ||
| instagramIcon.image = UIImage() | ||
| urlIcon.image = UIImage() | ||
| } |
| @@ -63,32 +63,22 @@ class GroupViewController: UIViewController { | |||
|
|
|||
| // 그룹 이름들을 담을 변수 생성 | |||
| var serverGroups: Groups? | |||
| var serverCards: CardsInGroupResponse? | |||
| var frontCards: [FrontCard]? = [] | |||
| } | ||
|
|
||
| extension QRScanViewController { | ||
| @objc func dismissQRScanViewController() { | ||
| NotificationCenter.default.post(name: .reloadGroupViewController, object: nil) |
| @@ -107,9 +97,26 @@ extension GroupViewController { | |||
| navigationController?.navigationBar.isHidden = true | |||
| } | |||
|
|
|||
| private func setNotification() { | |||
| NotificationCenter.default.addObserver(self, selector: #selector(didRecieveDataNotification(_:)), name: Notification.Name.passDataToGroup, object: nil) | |||
| NotificationCenter.default.addObserver(self, selector: #selector(scrollToTop), name: .reloadGroupViewController, object: nil) | |||
There was a problem hiding this comment.
요 reloadGRoupViewController은 Notification.Name안해두 먹히나요??
There was a problem hiding this comment.
넵! notification.name 을 확장하거든여
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📮 관련 이슈